Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MetaBaseItem tooltips crash when holding shift #3248

Merged
merged 2 commits into from
Sep 21, 2024
Merged

Fix MetaBaseItem tooltips crash when holding shift #3248

merged 2 commits into from
Sep 21, 2024

Conversation

querns
Copy link
Contributor

@querns querns commented Sep 21, 2024 •
edited by serenibyss
Loading

@serenibyss serenibyss added the bug fix Fix a bug. Please link it in the PR. label Sep 21, 2024
@NotAPenguin0 NotAPenguin0 mentioned this pull request Sep 21, 2024
Closed
NotAPenguin0
NotAPenguin0 reviewed Sep 21, 2024
View reviewed changes
Copy link
Contributor

@NotAPenguin0 NotAPenguin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this return an empty mutable list instead of the original list?

@querns
Copy link
Contributor Author

querns commented Sep 21, 2024

Should this return an empty mutable list instead of the original list?

The original IItemBehavior#getAdditionalTooltips method (in place before I changed it) returns the list, so the new method should as well. I think it's to allow the IItemBehavior to completely override the old list if it wants.

@chochem chochem merged commit e874e97 into GTNewHorizons:master Sep 21, 2024
5 checks passed
@querns querns deleted the tool-tooltip-crash branch September 21, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotAPenguin0 NotAPenguin0 NotAPenguin0 left review comments

@serenibyss serenibyss serenibyss approved these changes

Assignees
No one assigned
Labels
bug fix Fix a bug. Please link it in the PR.
Projects
None yet
Milestone
No milestone
4 participants
@querns @serenibyss @NotAPenguin0 @chochem